In one of my lectures our physics professor gave a derivation of the ideal rocket equation as follows:
Let $v_G > 0$ be the velocity at which the gas is emitted from the rocket. Let $m$ and $v$ be the mass and the velocity of the rocket at some point in time. The mass and velocity of the rocket change with $dm$ and $dv$ when some gas is emitted, so the new mass and velocity are $m - dm$ and $v + dv$. Let $v_T = v + dv + v_G$ be the velocity of the gas relative to the outside observer after it is emitted. The momentum of the whole system before and after the gas is emitted is equal:
$$mv = (m - dm)(v + dv) + dm \cdot v_T \Leftrightarrow mv = mv + mdv - vdm - dmdv + vdm + dmdv + v_Gdm \Leftrightarrow 0 = mdv + v_Gdm$$
By integrating this one can derive the ideal rocket equation.
Now as far as I can tell, my professor has done two mistakes here, which coincidentally seem to compensate each other, so that she reaches the correct solution nevertheless.
Firstly, the velocity of the emitted gas relative to the outside observer should be $v_T = v + dv - v_G$, since the gas is emitted in the opposite direction of the acceleration of the rocket.
Secondly, she implicitly says that $dm$ is positive, which is wrong since the mass of the rocket $m$ is decreasing over time. Thus, $dm < 0$. So the mass and velocity of the rocket after the gas is emitted should be $m + dm$ and $v + dv$. (See edit at the bottom)
With these two changes, the derivation looks like this:
$$mv = (m + dm)(v + dv) + (-dm) \cdot v_T \Leftrightarrow mv = mv + mdv + vdm + dmdv - vdm - dmdv + v_Gdm \Leftrightarrow 0 = mdv + v_Gdm$$
So we reach the same equation at the end.
Are the points I made valid and is it a mere coincidence that her mistakes compensate each other to reach a correct final solution? Or did I wrongly identify what she did as mistakes and there is a good explanation as to why she did those two things differently?
EDIT: Later in the derivation she integrates like this:
$\int_{m_0}^{m_1}-v_G\frac{dm}{m} = -v_G \int_{m_0}^{m_1}\frac{1}{m} dm = -v_G [ln(m)]_{m_0}^{m_1}$
So she is using $dm$ as the change of $m$, which means it has to be negative. Just to point this out; if $dm$ was actually positive, it should be labelled $d(-m)$ and the integration should go like this:
$v_G \int_{m_0}^{m_1}\frac{1}{m} d(-m) = -v_G \int_{m_0}^{m_1}\frac{1}{-m} d(-m) = -v_G [ln(m)]_{m_0}^{m_1}$